Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(readme): add neotest-gtest #331

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

alfaix
Copy link
Contributor

@alfaix alfaix commented Dec 10, 2023

Adding neotest-gtest to the list as it's now more-or-less functional.

Also wanted to mention - I wrote integration tests while working on the plugin, they allow writing tests like this from files like this. Would it make sense to contribute the testing tools to this plugin? Of course, configure_executable and things like that don't make sense for other adapters, but I think the general "write test project" -> "ensure it's running" flow would help with testing.

@rcarriga
Copy link
Collaborator

Thanks for the PR! 😄

Would it make sense to contribute the testing tools to this plugin?

I'm not sure they'd make much sense to upstream. Having a quick look, they're quite complex and I'd be worried about how abstract they could be that would make sense for other adapters without having to hack low level custom logic into them.

Although they are pretty cool, I personally wouldn't have much interest in them for the adapters that I maintain as I use them all and so I just test them through usage. They however aren't the most complex adapters I've seen so maybe not the best example.

IMO the ones you've written are better as example for adapter authors that may have an interest rather than the basis of a rather complex "library" of test functions

@rcarriga rcarriga merged commit 3f3784f into nvim-neotest:master Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants