Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Instance: Refactor: Node classes #2886

Closed
alex-courtis opened this issue Aug 25, 2024 · 1 comment · Fixed by #2950
Closed

Multi Instance: Refactor: Node classes #2886

alex-courtis opened this issue Aug 25, 2024 · 1 comment · Fixed by #2950
Assignees
@alex-courtis
Milestone
Multi Instance - ...

Comments

@alex-courtis
Copy link
Member

alex-courtis commented Aug 25, 2024 •
edited
Loading

Node classes are defined in node.lua however are created as tables.

Add Node classes and constructors.

This may not be necessary for multi instance.

nvim-tree.explorer.node is not explorer specific and should go into the Node class. It might be advisable to create a PR for just those class members first.
@alex-courtis alex-courtis converted this from a draft issue Aug 25, 2024
@alex-courtis alex-courtis mentioned this issue Aug 25, 2024
Closed
@alex-courtis alex-courtis mentioned this issue Sep 8, 2024
Merged
@alex-courtis alex-courtis mentioned this issue Sep 21, 2024
Merged
alex-courtis added a commit that referenced this issue Oct 7, 2024
@alex-courtis
refactor(#2871, #2886): multi instance: node classes created (#2916)
38aac09 
* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* node classes and constructors

* node methods

* refactor(#2875): multi instance renderer

* node classes and constructors

* explorer is a directory node

* extract methods from explore_node

* extract methods from explore_node

* extract methods from explore_node

* extract methods from lib

* use .. name for root node for compatibility

* use node.explorer

* extract node factory, remove unused code

* factories for all nodes, add RootNode

* factories for all nodes, add RootNode

* use factory pattern for decorators

* note regression and commit

* fix dir git status regression

* destroy nodes, not explorer

* add BaseNode:is

* revert changes to create-file, handle in #2924

* extract methods from explorer

* extract methods from explorer

* extract methods from explorer

* use Node everywhere in luadoc

* extract methods from lib

* extract methods from lib

* lint

* remove unused code

* don't call methods on fake root node

* get_node_at_cursor returns explorer (root) node instead of { name = '..' }

* remove unused inject_node

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* refactor(#2875): multi instance renderer

* extract methods from lib

* node factory uses stat only

* temporary DirectoryNode casting until method extraction into child classes

* lua-language-server 3.10.5 -> 3.11.0

* explicitly call Explorer constructor

* normalise explorer RootNode new call, tidy annotations
@alex-courtis
Copy link
Member Author

Classes created #2916

TODO:

  • Split Link into DirectoryLink and FileLink
  • Move methods from BaseNode into children
  • change link_to to absolute_path_target
  • Tighten members e.g. parent must be a DirectoryNode
  • Remove the Node alias, renaming BaseNode to Node
  • Remove tests such as #node.nodes to determine directory

alex-courtis added a commit that referenced this issue Oct 8, 2024
@alex-courtis
Revert "refactor(#2871, #2886): multi instance: node classes created (#…
50e9194 
…2916)"

This reverts commit 38aac09.
alex-courtis added a commit that referenced this issue Oct 11, 2024
@alex-courtis
Reapply "refactor(#2871, #2886): multi instance: node classes created (…
751410b 
…#2916)"

This reverts commit 50e9194.
alex-courtis added a commit that referenced this issue Oct 11, 2024
@alex-courtis
fix(#2945): stack overflow on api.git.reload or fugitive event with w…
5ad8762 
…atchers disabled (#2949)

* Reapply "refactor(#2871, #2886): multi instance: node classes created (#2916)"

This reverts commit 50e9194.

* fix(#2945): stack overflow on api.git.reload or fugitive event
alex-courtis added a commit that referenced this issue Oct 11, 2024
@alex-courtis
refactor(#2886): multi instance: node class refactoring: extract link…
dbe76bd 
…s, *_git_status (#2944)

* extract DirectoryLinkNode and FileLinkNode, move Node methods to children

* temporarily move DirectoryNode methods into BaseNode for easier reviewing

* move mostly unchanged DirectoryNode methods back to BaseNode

* tidy

* git.git_status_file takes an array

* update git status of links

* luacheck hack
alex-courtis added a commit that referenced this issue Oct 13, 2024
@alex-courtis
refactor(#2886): multi instance: node class refactoring: DirectoryNod…
cb041e0 
…e:expand_or_collapse (#2957)

move expand_or_collapse to DirectoryNode
alex-courtis added a commit that referenced this issue Oct 13, 2024
@alex-courtis
refactor(#2886): multi instance: node class refactoring: extract link…
98ca98c 
…s, *_git_status (#2944)

* extract DirectoryLinkNode and FileLinkNode, move Node methods to children

* temporarily move DirectoryNode methods into BaseNode for easier reviewing

* move mostly unchanged DirectoryNode methods back to BaseNode

* tidy

* git.git_status_file takes an array

* update git status of links

* luacheck hack
alex-courtis added a commit that referenced this issue Oct 13, 2024
@alex-courtis
refactor(#2886): multi instance: node class refactoring: DirectoryNod…
03f9dd2 
…e:expand_or_collapse (#2957)

move expand_or_collapse to DirectoryNode
@alex-courtis alex-courtis self-assigned this Oct 16, 2024
alex-courtis added a commit that referenced this issue Oct 20, 2024
@alex-courtis
refactor(#2886): multi instance: node group functions refactoring (#2959
8331a24 
)

* move last_group_node to DirectoryNode

* move add BaseNode:as and more doc

* revert parameter name changes

* revert parameter name changes

* add Class

* move group methods into DN

* tidy group methods

* tidy group methods

* tidy group methods

* tidy group methods

* parent is DirectoryNode

* tidy expand all

* BaseNode -> Node

* move watcher to DirectoryNode

* last_group_node is DirectoryNode only

* simplify create-file

* simplify parent

* simplify collapse-all

* simplify live-filter

* style
@alex-courtis alex-courtis mentioned this issue Oct 20, 2024
Merged
alex-courtis added a commit that referenced this issue Oct 25, 2024
@alex-courtis
refactor(#2886): multi instance: node class refactoring (#2950)
68be6df 
* add todo

* refactor(#2886): multi instance: node class refactoring: extract links, *_git_status (#2944)

* extract DirectoryLinkNode and FileLinkNode, move Node methods to children

* temporarily move DirectoryNode methods into BaseNode for easier reviewing

* move mostly unchanged DirectoryNode methods back to BaseNode

* tidy

* git.git_status_file takes an array

* update git status of links

* luacheck hack

* safer git_status_dir

* refactor(#2886): multi instance: node class refactoring: DirectoryNode:expand_or_collapse (#2957)

move expand_or_collapse to DirectoryNode

* refactor(#2886): multi instance: node group functions refactoring (#2959)

* move last_group_node to DirectoryNode

* move add BaseNode:as and more doc

* revert parameter name changes

* revert parameter name changes

* add Class

* move group methods into DN

* tidy group methods

* tidy group methods

* tidy group methods

* tidy group methods

* parent is DirectoryNode

* tidy expand all

* BaseNode -> Node

* move watcher to DirectoryNode

* last_group_node is DirectoryNode only

* simplify create-file

* simplify parent

* simplify collapse-all

* simplify live-filter

* style

* more type safety
@github-project-automation github-project-automation bot moved this from In review to Done in Multiple Instances Oct 25, 2024
alex-courtis added a commit that referenced this issue Oct 26, 2024
@alex-courtis
refactor(#2941): move lib methods to explorer (#2964)
f3efc25 
* add todo

* refactor(#2886): multi instance: node class refactoring: extract links, *_git_status (#2944)

* extract DirectoryLinkNode and FileLinkNode, move Node methods to children

* temporarily move DirectoryNode methods into BaseNode for easier reviewing

* move mostly unchanged DirectoryNode methods back to BaseNode

* tidy

* git.git_status_file takes an array

* update git status of links

* luacheck hack

* safer git_status_dir

* refactor(#2886): multi instance: node class refactoring: DirectoryNode:expand_or_collapse (#2957)

move expand_or_collapse to DirectoryNode

* refactor(#2886): multi instance: node group functions refactoring (#2959)

* move last_group_node to DirectoryNode

* move add BaseNode:as and more doc

* revert parameter name changes

* revert parameter name changes

* add Class

* move group methods into DN

* tidy group methods

* tidy group methods

* tidy group methods

* tidy group methods

* parent is DirectoryNode

* tidy expand all

* BaseNode -> Node

* move watcher to DirectoryNode

* last_group_node is DirectoryNode only

* simplify create-file

* simplify parent

* simplify collapse-all

* simplify live-filter

* style

* move lib.get_cursor_position to Explorer

* move lib.get_node_at_cursor to Explorer

* move lib.get_nodes to Explorer

* move place_cursor_on_node to Explorer

* resolve resource leak in purge_all_state

* move many autocommands into Explorer

* post merge tidy
alex-courtis added a commit that referenced this issue Nov 3, 2024
@alex-courtis
chore: resolve undefined-field warnings, fix link git statuses, rewri…
610a1c1 
…te devicons (#2968)

* add todo

* refactor(#2886): multi instance: node class refactoring: extract links, *_git_status (#2944)

* extract DirectoryLinkNode and FileLinkNode, move Node methods to children

* temporarily move DirectoryNode methods into BaseNode for easier reviewing

* move mostly unchanged DirectoryNode methods back to BaseNode

* tidy

* git.git_status_file takes an array

* update git status of links

* luacheck hack

* safer git_status_dir

* refactor(#2886): multi instance: node class refactoring: DirectoryNode:expand_or_collapse (#2957)

move expand_or_collapse to DirectoryNode

* refactor(#2886): multi instance: node group functions refactoring (#2959)

* move last_group_node to DirectoryNode

* move add BaseNode:as and more doc

* revert parameter name changes

* revert parameter name changes

* add Class

* move group methods into DN

* tidy group methods

* tidy group methods

* tidy group methods

* tidy group methods

* parent is DirectoryNode

* tidy expand all

* BaseNode -> Node

* move watcher to DirectoryNode

* last_group_node is DirectoryNode only

* simplify create-file

* simplify parent

* simplify collapse-all

* simplify live-filter

* style

* move lib.get_cursor_position to Explorer

* move lib.get_node_at_cursor to Explorer

* move lib.get_nodes to Explorer

* move place_cursor_on_node to Explorer

* resolve resource leak in purge_all_state

* move many autocommands into Explorer

* post merge tidy

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* Revert "chore: resolve undefined-field"

This reverts commit be546ff.

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* Revert "chore: resolve undefined-field"

This reverts commit e82db1c.

* chore: resolve undefined-field

* chore: class new is now generic

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* Revert "chore: resolve undefined-field"

This reverts commit 0e9b844.

* move icon builders into node classes

* move icon builders into node classes

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* chore: resolve undefined-field

* move folder specifics from icons to Directory

* move folder specifics from icons to Directory

* move folder specifics from icons to Directory

* move folder specifics from icons to Directory

* move file specifics from icons to File

* clean up sorters

* chore: resolve undefined-field

* tidy hl icon name

* file devicon uses library to fall back

* file devicon uses library to fall back

* file devicon uses library to fall back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-courtis alex-courtis

Labels
None yet
Projects
Multiple Instances
Status: Done
Milestone
Multi Instance - 1 - Refactor
Development

Successfully merging a pull request may close this issue.

refactor(#2886): multi instance: node class refactoring nvim-tree/nvim-tree.lua
1 participant
@alex-courtis