add support for chakracore #1828
Conversation
There was a problem hiding this comment.
Thanks for the PR - this certainly is a solid amount of work.
Please see my below comment; it might have been prudent to discuss the implementation before writing code, since I'd hate to see virtually all of this effort go to waste - but to add this kind of complexity to nvm requires careful consideration and planning.
| @@ -369,6 +373,8 @@ nvm_version_dir() { | |||
| nvm_echo "${NVM_DIR}/versions/node" | |||
| elif [ "_${NVM_WHICH_DIR}" = "_iojs" ]; then | |||
| nvm_echo "${NVM_DIR}/versions/io.js" | |||
| elif [ "_${NVM_WHICH_DIR}" = "_chakra" ]; then | |||
There was a problem hiding this comment.
chakra isn't the same category as "node" or "io.js" - it's an engine, not a platform. node and io.js are implicitly v8, so I'd want an entirely new way to explicitly specify the engine that you're using with the particular node version (and alias "v8" to the current implicit default)
The engine here is more akin to the way I've been planning to support nightlies and release candidates; and I'll want to make sure that engine support both works well with those, and doesn't force a specific implementation path for them.
There was a problem hiding this comment.
Ok, what syntax do you imagine then?
There was a problem hiding this comment.
for RCs, I'd initially begun with iojs:rc-v1.2.3 and node:rc-v4.5.6 (which would be the same here; you could do node:chakra, for example).
However, my in-progress branch also does some significant refactoring of the internals of nvm to be able to achieve this cleanly.
ljharb
added
feature requests
|
See #1067 as well for further discussion. |
|
Are you wanting to treat chakra RC and releases separately from v8? I had sortof assumed you'd just want an --engine flag, but am fine with whatever.
… On Jun 7, 2018, at 1:44 PM, Jordan Harband ***@***.***> wrote:
@ljharb commented on this pull request.
In nvm.sh:
> @@ -369,6 +373,8 @@ nvm_version_dir() {
nvm_echo "${NVM_DIR}/versions/node"
elif [ "_${NVM_WHICH_DIR}" = "_iojs" ]; then
nvm_echo "${NVM_DIR}/versions/io.js"
+ elif [ "_${NVM_WHICH_DIR}" = "_chakra" ]; then
for RCs, I'd initially begun with iojs:rc-v1.2.3 and node:rc-v4.5.6 (which would be the same here; you could do node:chakra, for example).
However, my in-progress branch also does some significant refactoring of the internals of nvm to be able to achieve this cleanly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
A flag would be nice; but that wouldn't allow specifying things in aliases or in |
|
Specifically, the use case I personally have in mind is being able to run tests in CI against v8-node and chakra-node, which means i need to be able to specify the engine in travis.yml's |
|
got it, thanks. so to be clear, something like
|
|
that seems reasonable, yes. if you want to update this PR with that in mind, i'll try to octopus merge it with my RC branch locally - we might be able to get both in at the same time, without conflicting. |
|
you haven't pushed any of your branch, right @ljharb ? |
|
It's not really in a state for that quite yet. |
👋
cc @mathias