[Docs] git install document update, sourcing nvm #2205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
May 4, 2020
README.md
Outdated
Comment on lines
172
to
173
| 2. `cd ~/.nvm` and check out the latest version with `git checkout v0.35.3` | ||
| 3. activate `nvm` by sourcing it from your shell: `. ./nvm.sh` |
There was a problem hiding this comment.
Suggested change
| 2. `cd ~/.nvm` and check out the latest version with `git checkout v0.35.3` | |
| 3. activate `nvm` by sourcing it from your shell: `. ./nvm.sh` | |
| 1. `cd ~/.nvm` and check out the latest version with `git checkout v0.35.3` | |
| 1. activate `nvm` by sourcing it from your shell: `. ./nvm.sh` |
using 1 for every item makes the numbering automatic.
ljharb
added
informational
installing nvm
|
@huahuayu this is still waiting for you to update the PR to resolve the issue i mentioned; are you still interested in completing the PR? |
ljharb
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please refer to the issue #2204