Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added parallel build support for obsd #2390

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

Nabstar
Copy link
Contributor

@Nabstar Nabstar commented Dec 26, 2020

num_of_cpu check is missing for OBSD Kindly merge the changes.

Co-authored-by: Lukman <lukmaan.me@gmail.com>
Co-authored-by: Sladyn Nunes <sladynnunes98@gmail.com>
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, seems reasonable

nvm.sh Outdated Show resolved Hide resolved
@ljharb
Copy link
Member

ljharb commented Dec 29, 2020

@Nabstar Just in case - please don't open a new PR, reuse this one.

@sladyn98
Copy link
Contributor

sladyn98 commented Mar 1, 2021

@Nabstar Are you still working on this PR, looks like the changes are ready to land 🚀 except a minor suggestion

@Nabstar
Copy link
Contributor Author

Nabstar commented Mar 1, 2021

No am not

@sladyn98
Copy link
Contributor

sladyn98 commented Mar 2, 2021

@ljharb https://github.com/sladyn98/nvm/pull/new/obsd-parallel
Put in the PR with the suggestions.

@ljharb ljharb added the installing node Issues with installing node/io.js versions. label Mar 4, 2021
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 1081ed1 into nvm-sh:master Mar 4, 2021
@ljharb ljharb mentioned this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installing node Issues with installing node/io.js versions. OS: FreeBSD / OpenBSD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants