Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to npm-groovy-lint 12.0.0 #182

Closed
wants to merge 1 commit into from
Closed

Conversation

nvuillam
Copy link
Owner

@nvuillam nvuillam commented Nov 4, 2023

Minimum java version is now 17

Minimum java version is now 17
Copy link

github-actions bot commented Nov 4, 2023

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.13s
✅ JSON eslint-plugin-jsonc 16 0 0 2.62s
✅ JSON jsonlint 16 0 0.27s
✅ JSON npm-package-json-lint yes no 0.77s
✅ JSON prettier 16 0 0 2.08s
✅ JSON v8r 16 0 17.33s
⚠️ MARKDOWN markdownlint 4 0 10 1.03s
❌ MARKDOWN markdown-link-check 4 4 66.54s
✅ MARKDOWN markdown-table-formatter 4 0 0 0.41s
❌ REPOSITORY checkov yes 4 13.83s
✅ REPOSITORY dustilock yes no 2.56s
✅ REPOSITORY gitleaks yes no 1.25s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY secretlint yes no 1.0s
✅ REPOSITORY syft yes no 0.28s
❌ REPOSITORY trivy yes 1 5.01s
❌ SPELL cspell 31 1 4.84s
✅ SPELL misspell 30 0 0 0.11s
✅ YAML prettier 7 0 0 1.03s
✅ YAML v8r 7 0 12.44s
✅ YAML yamllint 7 0 0.32s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@nvuillam
Copy link
Owner Author

nvuillam commented Nov 4, 2023

@stevenh oops with 12.0.0 :(
Help ? ❤️

@djukxe
Copy link

djukxe commented Nov 23, 2023

Hi @nvuillam I would like to give it a shot 🔥
Could you please run test workflow on current 2.0.0 version?
It seems tests were already failing back then but runs history have been purged and I would like to be sure I get same error when I test locally

@stevenh
Copy link
Collaborator

stevenh commented Nov 23, 2023

I do have a big rewrite of the tests pending, as I found that currently they are very dependent on internal state, so when running locally, including independently they are very flaky.

Haven't had much time recently as been busy at work. Hopefully in the next few weeks, todays job is getting CodeNarc fix in kindly done by @chrismair 👍

@nvuillam
Copy link
Owner Author

@stevenh that's great, many thanks !

If you think @djukxe can help you, please invite him to work on your fork / branch :)

@stevenh
Copy link
Collaborator

stevenh commented Nov 23, 2023

Need to get some more issues fixed in npm-groovy-lint first.

@nvuillam nvuillam closed this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants