src: update GetForegroundTaskRunner override

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5758110
nwjs · Oct 15, 2024 · a6f950c · a6f950c
1 parent 4e2c97b
commit a6f950c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/node_platform.cc b/src/node_platform.cc
@@ -556,8 +556,8 @@ bool NodePlatform::IdleTasksEnabled(Isolate* isolate) {
   return ForIsolate(isolate)->IdleTasksEnabled();
 }
 
-std::shared_ptr<v8::TaskRunner>
-NodePlatform::GetForegroundTaskRunner(Isolate* isolate) {
+std::shared_ptr<v8::TaskRunner> NodePlatform::GetForegroundTaskRunner(
+    Isolate* isolate, v8::TaskPriority priority) {
   return ForIsolate(isolate)->GetForegroundTaskRunner();
 }
 

diff --git a/src/node_platform.h b/src/node_platform.h
@@ -182,7 +182,7 @@ class NodePlatform : public MultiIsolatePlatform {
                                   void* data) override;
 
   std::shared_ptr<v8::TaskRunner> GetForegroundTaskRunner(
-      v8::Isolate* isolate) override;
+      v8::Isolate* isolate, v8::TaskPriority priority) override;
 
   Platform::StackTracePrinter GetStackTracePrinter() override;
   v8::PageAllocator* GetPageAllocator() override;

diff --git a/test/cctest/test_platform.cc b/test/cctest/test_platform.cc
@@ -24,7 +24,8 @@ class RepostingTask : public v8::Task {
     if (repost_count_ > 0) {
       --repost_count_;
       std::shared_ptr<v8::TaskRunner> task_runner =
-          platform_->GetForegroundTaskRunner(isolate_);
+          platform_->GetForegroundTaskRunner(isolate_,
+                                             v8::TaskPriority::kUserBlocking);
       task_runner->PostTask(std::make_unique<RepostingTask>(
           repost_count_, run_count_, isolate_, platform_));
     }
@@ -46,7 +47,8 @@ TEST_F(PlatformTest, SkipNewTasksInFlushForegroundTasks) {
   Env env {handle_scope, argv};
   int run_count = 0;
   std::shared_ptr<v8::TaskRunner> task_runner =
-      platform->GetForegroundTaskRunner(isolate_);
+      platform->GetForegroundTaskRunner(isolate_,
+                                        v8::TaskPriority::kUserBlocking);
   task_runner->PostTask(
       std::make_unique<RepostingTask>(2, &run_count, isolate_, platform.get()));
   EXPECT_TRUE(platform->FlushForegroundTasks(isolate_));