dockerize lhd #45
dockerize lhd #45
Conversation
kozr
requested review from
Ciuffi,
AustinKobayashi,
Eric1015,
ianmah,
luceliu and
StanfordLin
docker-compose.yml
Outdated
| command: yarn run dev | ||
| working_dir: /usr/src/nuxt-app | ||
| volumes: | ||
| - .\:/usr/src/nuxt-app |
There was a problem hiding this comment.
.\ doesn't work on unix machines, like macs, use just . instead
There was a problem hiding this comment.
Wish I could join u guys for dinner instead of doing hwk and stuff ;(
Dockerfile
Outdated
| WORKDIR /usr/src/nuxt-app | ||
| COPY package*.json yarn.lock ./ | ||
| RUN yarn install | ||
| RUN npm rebuild node-sass |
There was a problem hiding this comment.
This shouldn't need to happen if the modules are installed for linux already
There was a problem hiding this comment.
Are you referring to the npm rebuild node-sass?
There was a problem hiding this comment.
sass/node-sass#2536 I was getting some error highly related with this. I had to use npm rebuild node-sass to fix it on my computer.
There was a problem hiding this comment.
I think this makes it work because it rebuilds the node modules in your host computers node folder into Linux versions. What we want is tell docker to use the node modules built into the docker image already. I explained on slack how to do this, it’s a pretty simple addition to the volumes field.
There was a problem hiding this comment.
Add a new volume:
- /usr/src/nuxt-app/node_modules
Under the other volume mount in the docker compose
docker-compose.yml
Outdated
| version: '3.7' | ||
| services: | ||
| nuxt: | ||
| image: kozr/lhd2020_nuxt |
There was a problem hiding this comment.
We probably want to be able to rebuild the container in case we add more node modules, we should use build instead of a preset image.
.dockerignore
Outdated
| @@ -0,0 +1,4 @@ | |||
| node_modules | |||
There was a problem hiding this comment.
Just an FYI, dockerignore only affects the building of the image, not the volume mounts
|
can you add instructions for using this cuz idk what im supposed to do |
|
@ianmah Theres some in the Readme, do you think we should add more? |
|
oops i didn't mean to merge this.. |
please check if it's correct