-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename nw exe #712
fix: rename nw exe #712
Conversation
In my opinion, this should default to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still feel users should be able to specify a name other than the name
property in package.json
. Users should be able to add an appName
(or some other property) to the nwbuild
configuration object, which would override the default name
.
I agree that there should be a way to change app name, but I'd like to keep that for another PR. I first want to figure out the platform specific configs and after they all work, let the user customise them. |
Changes
name
property ofsrcDir/package.json