Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename nw exe #712

Merged
merged 21 commits into from
Nov 26, 2022
Merged

fix: rename nw exe #712

merged 21 commits into from
Nov 26, 2022

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Nov 26, 2022

Changes

  • Rename NW executable to name property of srcDir/package.json

@ayushmanchhabra
Copy link
Collaborator Author

@sysrage in v3.8.6 the NW executable is renamed to the appName argument. What do you think of changing it to the value in the package.json's name property?

@sysrage
Copy link
Contributor

sysrage commented Nov 26, 2022

@sysrage in v3.8.6 the NW executable is renamed to the appName argument. What do you think of changing it to the value in the package.json's name property?

In my opinion, this should default to name from package.json. However, users should be able to override that name with nwbuild.appName (or something similar).

src/bld/package.js Outdated Show resolved Hide resolved
Copy link
Contributor

@sysrage sysrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still feel users should be able to specify a name other than the name property in package.json. Users should be able to add an appName (or some other property) to the nwbuild configuration object, which would override the default name.

src/bld/winCfg.js Outdated Show resolved Hide resolved
@ayushmanchhabra
Copy link
Collaborator Author

ayushmanchhabra commented Nov 26, 2022

I still feel users should be able to specify a name other than the name property in package.json. Users should be able to add an appName (or some other property) to the nwbuild configuration object, which would override the default name.

I agree that there should be a way to change app name, but I'd like to keep that for another PR. I first want to figure out the platform specific configs and after they all work, let the user customise them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants