fix: file globing #785
Merged
fix: file globing #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o fix/cli-file-glob
rickymohk
reviewed
Feb 7, 2023
| log.debug(`Copy ${file} file to ${outDir} directory`); | ||
| await cp( | ||
| file, | ||
| `${outDir}/${ | ||
| platform !== "osx" ? "package.nw" : "nwjs.app/Contents/Resources/app.nw" | ||
| }/${basename(file)}`, | ||
| }/${file.split(sep).splice(2).join(sep)}`, |
There was a problem hiding this comment.
This line causes problem on windows. "/" instead of sep should be used here (The rest of the path is already using "/"). file comes from glob expanded srcDir, which always use "/". split(sep) split nothing on windows causing the subdirectory to disappear.
There was a problem hiding this comment.
Can you open a bug report referencing this line or a pull request to fix this?
There was a problem hiding this comment.
I'm working on getting Windows builds working in #795. I realise I need to use path.resolve which would remove the need for sep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
Description
Undocumented bug discovered through Stack Overflow.
node-globand yargs file glob seem to work differently. For now, one can tweak the glob pattern for CLI to match the required files and directories. Anoptions.cliflag is set totrueon each CLI run. This preventsnode-globfrom doing twice the work and erroring out with the error message as mentioned in the Stack Overflow post.With module usage, the copied file
subdir/file.jswould be copied asoutDir/package.nw/file.js. This is now fixed and is copied asoutDir/package.nw/subdir/file.js.