Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent nuking options.app, use absolute path for rcedit #815

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

williamwang96
Copy link
Contributor

@williamwang96 williamwang96 commented Mar 9, 2023

Description

Fixes: #812
Fixes: #813

@ayushmanchhabra ayushmanchhabra changed the title Dev 812 and 813 fix: prevent nuking options.app, use absolute path for rcedit Mar 10, 2023
@ayushmanchhabra ayushmanchhabra merged commit ff8f4e7 into nwutils:main Mar 10, 2023
@williamwang96 williamwang96 deleted the dev-812-and-813 branch March 10, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded path to .exe doesn't work for rcedit User-passed-in options in options.app are not respected
2 participants