Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate version #835

Merged
merged 7 commits into from
Mar 30, 2023
Merged

fix: validate version #835

merged 7 commits into from
Mar 30, 2023

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Mar 30, 2023 •
edited
Loading

Fixes: #823

Description

  • Throw error if releaseInfo is undefined (this implies version is invalid).
  • Renamed getManifest to getVersionManifest to avoid confusion of what the heck is the manifest anyway?
  • Clarify basic usage in docs

@ayushmanchhabra ayushmanchhabra merged commit 68d3593 into main Mar 30, 2023
@ayushmanchhabra ayushmanchhabra deleted the dev-823 branch March 30, 2023 15:26
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not handling missing version in manifest.json
1 participant
@ayushmanchhabra