Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change manifest cache impl #888

Merged
merged 4 commits into from
Jun 28, 2023
Merged

fix: change manifest cache impl #888

merged 4 commits into from
Jun 28, 2023

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Jun 27, 2023 •
edited
Loading

Fixes: #822

Description

  • Redownload manifest.json every time the nwbuild function is executed.
  • If manifest.json already exists and we are unable to connect to the nwjs.io domain (network related issues), then use the existing manifest.
  • If no manifest.json exists in the cache dir, then the validate function will catch this and throw an error - preventing the build.

@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review June 27, 2023 17:43
@ayushmanchhabra
Copy link
Collaborator Author

ayushmanchhabra commented Jun 27, 2023 •
edited
Loading

@sysrage I feel like this PR strikes a good balance w.r.t the discussion in #822.

cc @williamwang96

williamwang96
williamwang96 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@williamwang96 williamwang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and is exactly what I was thinking!

@ayushmanchhabra ayushmanchhabra merged commit 3bb9489 into main Jun 28, 2023
@ayushmanchhabra ayushmanchhabra deleted the dev-822 branch June 28, 2023 06:45
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamwang96 williamwang96 williamwang96 approved these changes

@sysrage sysrage Awaiting requested review from sysrage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache never expires
2 participants
@ayushmanchhabra @williamwang96