fix: ffmpeg path on some macos envs #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/util/ffmpeg.js
|
@ayushmanchhabra for some reason the file copy works on my Mac but was failing on circle ci. I've updated the Mac ffmpeg copy to handle both on the plus side I see all the checks pass now... well done |
|
@ayushmanchhabra would you mind merging this. I need it to get my CI pipeline going |
ayushmanchhabra
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #916
some versions of node/macOS complain about destination being a file, and others complain when it is only a directory. the only thing I can think to do is to try both