fix(get): cache ffmpeg #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zkrige
commented
Sep 4, 2023
zkrige
commented
- Caches ffmpeg
- splits get into get_nwjs and get_ffmpeg
# Conflicts: # changelog.md # package-lock.json # package.json # src/get_nwjs.js
remove unnecessary unzip for macos
|
Looks good except for the test you added (it doesn't really test the caching behaviour). I think we can remove it, merge this in and I'll think of how to test this behaviour (maybe use some fixtures). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.