Shrinking uuu.cpp #207
Open
Shrinking uuu.cpp #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Boost is too fat. |
|
Please fix build error |
markuspg
force-pushed
the
master
branch
2 times, most recently
from
025f322
to
73b19ae
Compare
The class' purpose fits to the new location and a new more descriptive name was given.
markuspg
force-pushed
the
master
branch
5 times, most recently
from
b4f2957
to
b1583ba
Compare
nxpfrankli
force-pushed
the
master
branch
4 times, most recently
from
1ccae76
to
39d45e5
Compare
nxpfrankli
force-pushed
the
master
branch
15 times, most recently
from
1597a12
to
0f8362f
Compare
nxpfrankli
force-pushed
the
master
branch
10 times, most recently
from
629d224
to
8925b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi nxpfrankli,
here is another (possibly last) slew of adjustments. This time it's mostly about shortening uuu.cpp and respective source files. They are mostly cosmetic, but change quite a bit of the code's structure. Feel encouraged to reject it if it does not fit your coding style.
Thank you for offering "real" problems to work on. Most of the changes grew out of wanting to make debugging and navigating the code (which I had to do at my paid work) easier and helping myself to wrap my head around it. Your issues sound interesting, but at least during my work weeks I don't have energy and time left doing some "real" changes. Maybe if I'm bored during holidays ;-)
Did you ponder using a library like Boost.Beast for HTTP instead writing the code yourself?
Kind regards,
markuspg