buffer: truncate instead of throw when writing beyond buffer

Fixes: nodejs#54523 PR-URL: nodejs#54524
nxtedition · Aug 23, 2024 · ff17b6b · ff17b6b
1 parent d5dc540
commit ff17b6b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/lib/internal/buffer.js b/lib/internal/buffer.js
@@ -1040,9 +1040,6 @@ function addBufferPrototypeMethods(proto) {
     if (offset < 0 || offset > this.byteLength) {
       throw new ERR_BUFFER_OUT_OF_BOUNDS('offset');
     }
-    if (length < 0 || length > this.byteLength - offset) {
-      throw new ERR_BUFFER_OUT_OF_BOUNDS('length');
-    }
     return asciiWriteStatic(this, string, offset, length);
   };
   proto.base64Write = base64Write;
@@ -1051,9 +1048,6 @@ function addBufferPrototypeMethods(proto) {
     if (offset < 0 || offset > this.byteLength) {
       throw new ERR_BUFFER_OUT_OF_BOUNDS('offset');
     }
-    if (length < 0 || length > this.byteLength - offset) {
-      throw new ERR_BUFFER_OUT_OF_BOUNDS('length');
-    }
     return latin1WriteStatic(this, string, offset, length);
   };
   proto.hexWrite = hexWrite;
@@ -1062,9 +1056,6 @@ function addBufferPrototypeMethods(proto) {
     if (offset < 0 || offset > this.byteLength) {
       throw new ERR_BUFFER_OUT_OF_BOUNDS('offset');
     }
-    if (length < 0 || length > this.byteLength - offset) {
-      throw new ERR_BUFFER_OUT_OF_BOUNDS('length');
-    }
     return utf8WriteStatic(this, string, offset, length);
   };
 }

diff --git a/test/parallel/test-buffer-write.js b/test/parallel/test-buffer-write.js
@@ -106,3 +106,10 @@ assert.strictEqual(Buffer.alloc(4)
   assert.strictEqual(buf.write('ыы', 1, 'utf16le'), 4);
   assert.deepStrictEqual([...buf], [0, 0x4b, 0x04, 0x4b, 0x04, 0, 0, 0]);
 }
+
+
+{
+  const buf = Buffer.alloc(1);
+  assert.strictEqual(buf.write('ww', 1));
+  assert.strictEqual(buf.toString() === 'w');
+}