events: patch override alias of on/addListener and off/removeListener
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously these used alias which caused surprising behaviour when trying to override add/removeListener, e.g. Readable. This resolves this by making add/remove actually call the corresponding function through the prototype chain.
ronag
force-pushed
the
fix-events2
branch
2 times, most recently
from
9860eaa to
399a089
Compare
4 tasks
ronag
force-pushed
the
fix-events2
branch
3 times, most recently
from
412291c to
41bc7c1
Compare
|
Question, should this patch the prototype (fast) or the instance (slow)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically fix override alias of
on/addListenerandoff/removeListenerChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes