[base64] decoding input-buffers that have '\0' #12

daminetreg · 2021-08-18T07:27:25Z

We had an issue in the decode64 function that didn't correctly decode back to buffer with the exact same number of nullptr.

…end.

daminetreg · 2021-08-18T13:43:22Z

Hey @pysco68 now ready for review 👍

test/base64.cpp

xxhr/util.hpp

daminetreg

count before transform_width It, to avoid creating 2 copies and simplify code. Thanks

…ng-nullptr-ending-buffer

pysco68

LGTM

daminetreg added 2 commits August 18, 2021 08:50

🔧 Handle padding correctly instead of all encoded \0

fbd2ef2

🔧 Handle padding correctly instead of removing all encoded \0 at the …

513239d

…end.

daminetreg requested a review from pysco68 August 18, 2021 07:27

daminetreg self-assigned this Aug 18, 2021

daminetreg added 2 commits August 18, 2021 11:15

🔧 wasm doesn't provide sigaltstack impl, fix boost test on the platform.

1d154c1

💄 compiles better with the missing file.

44df7b3

pysco68 reviewed Aug 18, 2021

View reviewed changes

test/base64.cpp Show resolved Hide resolved

xxhr/util.hpp Outdated Show resolved Hide resolved

daminetreg commented Aug 18, 2021

View reviewed changes

daminetreg added 2 commits August 19, 2021 10:07

Merge branch 'master' of github.com:nxxm/xxhr into feature/fix-decodi…

a73513b

…ng-nullptr-ending-buffer

💄 less allocation, simpler decode64 as of boost patch.

fb72f7d

daminetreg requested a review from pysco68 August 25, 2021 16:07

pysco68 approved these changes Aug 26, 2021

View reviewed changes

pysco68 merged commit ad85c4e into master Aug 26, 2021

Provide feedback