Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle http errors more gracefully #1252

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Handle http errors more gracefully #1252

merged 3 commits into from
Nov 8, 2024

Conversation

ericnewcomer
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 4.76190% with 40 lines in your changes missing coverage. Please review.

Project coverage is 64.47%. Comparing base (19a422a) to head (547a849).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/store/thunks.ts 0.00% 19 Missing ⚠️
src/store/helpers.ts 0.00% 10 Missing ⚠️
src/components/revisions/RevisionExplorer.tsx 22.22% 5 Missing and 2 partials ⚠️
src/components/simulator/Simulator.tsx 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (19a422a) and HEAD (547a849). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (19a422a) HEAD (547a849)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
- Coverage   71.68%   64.47%   -7.21%     
==========================================
  Files         181      181              
  Lines        7087     7093       +6     
  Branches     1677     1679       +2     
==========================================
- Hits         5080     4573     -507     
- Misses       1920     1941      +21     
- Partials       87      579     +492     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericnewcomer ericnewcomer merged commit 775400d into main Nov 8, 2024
3 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
@ericnewcomer ericnewcomer deleted the http-errors branch November 8, 2024 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant