Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop setting delete_reason on runs before deletion #63

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

rowanseymour
Copy link
Member

Requires nyaruka/rapidpro#3702 be deployed first

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #63 (e9db46c) into main (43aae95) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   68.21%   68.34%   +0.12%     
==========================================
  Files           6        6              
  Lines         818      815       -3     
==========================================
- Hits          558      557       -1     
+ Misses        149      148       -1     
+ Partials      111      110       -1     
Impacted Files Coverage Δ
archives/runs.go 66.23% <ø> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43aae95...e9db46c. Read the comment docs.

@rowanseymour rowanseymour merged commit ebbc918 into main Feb 24, 2022
@rowanseymour rowanseymour deleted the no_more_delete_reason branch February 24, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants