Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize, format, add tracing, adjust log levels #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orangecms
Copy link

@orangecms orangecms commented Feb 23, 2023

Used in: https://github.com/orangecms/vf2-loader
Demo: https://twitter.com/OrangeCMS/status/1628844843949608961

Everything else:

  • foo()?; instead of try!(foo()); as suggested by Clippy
  • add trace!() for inidividual byte transfers (that helped...)
  • raise some debug!() to !info()
  • take returned transfer counts

EDIT:
I had initially raised the maximum error count from 16 to 32, but discarded that again.

@orangecms orangecms changed the title modernize, format, raise max errors, add tracing modernize, format, add tracing, adjust log levels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant