Optimize Memory and Performance in waveform.js #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces a series of optimizations aimed at improving the performance and memory usage of the waveform.js file. The changes focus on pre-allocating arrays where possible, optimizing array manipulations, and replacing library-specific methods with native JavaScript alternatives where appropriate. Key Changes: - Pre-allocated the samples array as a Float64Array to reduce dynamic memory allocations. - Introduced sampleCount to keep track of the number of samples, allowing us to trim the pre-allocated samples array to its actual size. - Replaced the non-existent d3.maxIndex function with native JavaScript code to find the index of the maximum RMS value. These changes aim to enhance the performance and reduce the memory footprint of the getWaveform function, especially when working with large audio files. Please review and test these changes thoroughly to ensure they meet all functional and performance requirements.
|
Do you have this building successfully locally or through docker? I've been running into issues with the original branch on Docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a series of optimizations aimed at improving the performance and memory usage of the waveform.js file. The changes focus on pre-allocating arrays where possible, optimizing array manipulations, and replacing library-specific methods with native JavaScript alternatives where appropriate.
Key Changes:
These changes aim to enhance the performance and reduce the memory footprint of the getWaveform function, especially when working with large audio files.
Please review and test these changes thoroughly to ensure they meet all functional and performance requirements.