Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Will/Did Dismiss Delegate Methods No Longer Called On Interactive Dismissal #129

Closed
bcapps opened this issue Jan 14, 2016 · 0 comments
Closed

Will/Did Dismiss Delegate Methods No Longer Called On Interactive Dismissal #129

bcapps opened this issue Jan 14, 2016 · 0 comments
Assignees
@cdzombak
Labels
bug

Comments

@bcapps
Copy link
Contributor

bcapps commented Jan 14, 2016

It looks like with the recent change in 1.0 the dismissal delegate methods are no longer called when dismissing interactively. It may potentially be the addition of this line that prevents them from being called since interactive dismissals do not set forcesNonInteractiveDismissal, but should still generate the delegate calls.
@bcapps bcapps added the bug label Jan 14, 2016
cdzombak added a commit that referenced this issue Jan 14, 2016
@cdzombak
Fix delegate calls on interactive dismissal transitions
c0c2040 
closes #129

This was a stupid reversed-logic bug. I even tried extracting this to a boolean to keep the logic straight, but something with the "forces non interactive" naming messed with my head, I guess.
@cdzombak cdzombak mentioned this issue Jan 14, 2016
Merged
@cdzombak cdzombak mentioned this issue Jan 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdzombak cdzombak

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcapps @cdzombak