Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading spinner does not show when photo source is set back to nil after being set to some value #186

Closed
brianneisler opened this issue Apr 19, 2016 · 1 comment
Closed

Loading spinner does not show when photo source is set back to nil after being set to some value #186

brianneisler opened this issue Apr 19, 2016 · 1 comment

Comments

@brianneisler
Copy link
Contributor

brianneisler commented Apr 19, 2016 •
edited
Loading

Steps to reproduce

  • init photosViewController with a photo that has photo.image = nil;
  • present PhotoViewController
  • update photo.image
photo.image = [UIImage imageWithData: data];
[self.photoViewer updateImageForPhoto:photo];
  • dismiss PhotoViewController
  • set photo.image back to nil
photo.image = nil; 
[self.photoViewer updateImageForPhoto:photo];
  • present PhotoViewController
  • update photo.image to some new source
photo.image = [UIImage imageWithData: data];
[self.photoViewer updateImageForPhoto:photo];

What should happen

  • the spinner shows up the first time
  • the spinner should also show up the second time when the photo source is set back to nil

What actually happens

  • the spinner shows up the first time
  • the photo viewer is black for a moment and then the new image shows up
@brianneisler brianneisler mentioned this issue Apr 19, 2016
Merged
@cdzombak
Copy link
Contributor

closed by #187; thanks for your contribution, @brianneisler!

shagedorn pushed a commit to iosphere/NYTPhotoViewer that referenced this issue Sep 27, 2016
Merge branch 'master' into master_iosphere
c41241d 
* master:
  Update CHANGELOG for v1.2.0
  Bump to version 1.2.0
  Add framework target version numbers to release checklist
  Remove bridging header reference in README
  Update CHANGELOG.md
  Recommend that a delegate should be given to NYTPhotosVC designated initializer
  Readd loading view when photo source is set back to nil. Fixes issue nytimes#186.
  Update CHANGELOG with changes currently on develop
  Remove `ANIMATED_GIF_SUPPORT` preprocessor conditionals from unit tests
  Sync dependency versions specified between CocoaPods and Carthage
  Include all files in the bundle, not just PNGs, in Cocoapods resource bundle
  Remove default boilerplate from ObjC Example's app delegate
  Add basic Carthage installation info to README
  Fix gradient flickering of caption view on iOS 9
  Fixed workspace issues
  Removed absolute references
  Added Swift Example
  Added support for Carthage
  Remove Todo section from README in favor of issue tracker
  Update version number in README Podfile docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdzombak @brianneisler