Support plugin/preset definitions without prefixes in .babelrc (#303) #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delambo
approved these changes
Oct 30, 2016
|
@zdoc01 - Can you quickly look into making a unit test for this. I think we stub out the babelrc so this may be hard to test. Since this is pretty simple and will only temporarily live in the project I'm not terribly concerned about a test but if you find that it is easy to add, please do. Also, feel free to do it in a follow-up pull request. |
tizmagik
approved these changes
Oct 31, 2016
|
Closed since I know you're working against the clock @zdoc01. Please see my comment above and followup with a pull if it's possible. |
|
@delambo - Sorry, I didn't get a chance to respond yesterday. I'll happily take a look at adding a test when I get the chance. May not be today, but hopefully tomorrow at the latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #303. Still supports
babel-*plugins and presets in.babelrc, as well as without the prefixes. Also still supports relative and absolute paths.