Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test from root directory #336

Merged
merged 3 commits into from
Dec 10, 2016
Merged

Run test from root directory #336

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77b4cb2
changes test script to run in root directory instead of locally in pa…
delambo Dec 10, 2016
a1d0f31
ugh, jest needs to be installed in the top level package for some reason
delambo Dec 10, 2016
1222ba1
keep kyt-core and top level package jest versions in sync
delambo Dec 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,16 @@
"directories": {
"doc": "docs"
},
"jest": {
"testPathIgnorePatterns": [
"<rootDir>/packages/starter-kyts",
"<rootDir>/e2e_tests"
]
},
"scripts": {
"test": "jest --testPathPattern /__tests__/",
"test": "jest",
"test-watch": "jest --watch",
"test-coverage": "jest --coverage",
"e2e": "jest --config ./e2e_tests/jest.config.json --verbose --no-cache",
"lint": "packages/kyt-core/node_modules/.bin/eslint --config packages/kyt-core/.eslintrc.json --ignore-pattern **/node_modules --ignore-pattern packages/starter-kyts ./"
},
Expand All @@ -22,8 +30,8 @@
},
"homepage": "https://github.com/NYTimes/kyt#readme",
"dependencies": {
"jest": "16.0.2",
"ps-tree": "1.1.0",
"shelljs": "0.7.5"
"shelljs": "0.7.5",
"jest": "17.0.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we upgrade Jest to 17 in kyt-core too? There may be some breaking changes we'll want to look into. How much do we care about keeping them in sync?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not right now. I think we should keep them in sync. Fixed.

}
}
2 changes: 0 additions & 2 deletions packages/kyt-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@
"kyt-cli": "index.js"
},
"scripts": {
"test": "jest --testPathPattern /__tests__/"
},
"license": "Apache-2.0",
"devDependencies": {
"jest": "16.0.2"
},
"dependencies": {
"commander": "2.9.0",
Expand Down
4 changes: 0 additions & 4 deletions packages/kyt-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@
"node": ">=6.1.0"
},
"scripts": {
"test": "jest --testPathPattern /__tests__/",
"e2e": "jest --config ./e2e_tests/jest.config.json --verbose --no-cache",
"test-watch": "jest --watch",
"test-coverage": "jest --coverage"
},
"repository": {
"type": "git",
Expand Down
2 changes: 0 additions & 2 deletions packages/kyt-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
"description": "A shared kyt utility library.",
"main": "logger.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"devDependencies": {
"jest": "16.0.2"
},
"author": "NYTimes",
"license": "Apache-2.0"
Expand Down