Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making kyt a dependency rather than a devDependency #387

Merged
merged 1 commit into from
Feb 12, 2017
+5 −5
Merged

Making kyt a dependency rather than a devDependency #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/kyt-cli/cli/actions/setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ module.exports = (flags, args) => {
};

// Add kyt to list of dev dependencies if its not there
const addKytDevDependency = (packageJson, kytPrefVersion) => {
const addKytDependency = (packageJson, kytPrefVersion) => {
// eslint-disable-next-line max-len
// check to see if kyt is in dependencies or devDependencies
if (!(packageJson.dependencies && packageJson.dependencies.kyt) &&
Expand All @@ -70,8 +70,8 @@ module.exports = (flags, args) => {
const output = shell.exec('npm info kyt version');
kytVersion = output.stdout.trim();
}
packageJson.devDependencies = packageJson.devDependencies || {};
packageJson.devDependencies.kyt = kytVersion;
packageJson.dependencies = packageJson.dependencies || {};
packageJson.dependencies.kyt = kytVersion;
}
};

Expand Down Expand Up @@ -184,10 +184,10 @@ module.exports = (flags, args) => {
if (!existingProject) {
const kytPrefVersion = args.kytVersion || checkStarterKytVersion(userPackageJSON);
userPackageJSON = updatePackageJSONDependencies(userPackageJSON);
addKytDevDependency(userPackageJSON, kytPrefVersion);
addKytDependency(userPackageJSON, kytPrefVersion);
} else {
// exisitng projects should also have kyt as a devDependency
addKytDevDependency(userPackageJSON);
addKytDependency(userPackageJSON);
}
// Add scripts
userPackageJSON = addPackageJsonScripts(userPackageJSON);
Expand Down