Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more functional tests #388

Merged
merged 1 commit into from
Feb 12, 2017
Merged

Conversation

delambo
Copy link
Member

@delambo delambo commented Feb 12, 2017

I added functional tests for kyt lint-script and kyt-lint-style. I'd like to add more in followup pull requests, but I'd like to get feedback on this first.

To get this to run fast, I setup fixtures with the files needed to run each command. Before each test, I add a symlink to kyt-core so we can test against the latest without having to wait for a package install.

@delambo delambo force-pushed the adds-more-functional-tests branch 2 times, most recently from 31f9782 to 6d8113d Compare February 12, 2017 19:15
@delambo delambo changed the title [WIP] adds more functional tests Adds more functional tests Feb 12, 2017
cleans up lint errors

fixes starter kyt tests

fixes core rc version in starters
@delambo delambo force-pushed the adds-more-functional-tests branch from 6d8113d to 15f8f22 Compare February 12, 2017 19:47
Copy link
Contributor

@ccpricenytimes ccpricenytimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ccpricenytimes ccpricenytimes merged commit 6758ff3 into master Feb 12, 2017
@ccpricenytimes ccpricenytimes deleted the adds-more-functional-tests branch February 12, 2017 21:07
tizmagik added a commit that referenced this pull request Feb 17, 2017
* master: (26 commits)
  Expand version range of yarn for Travis (#400)
  update migration guide to 0.4.0 (#398)
  Update CHANGELOG.md
  adds 040 final version (#392)
  0.4.0 docs (#338)
  adds yarn version check to bootstrap (#391)
  Making kyt a dependency rather than a devDependency (#387)
  adds more functional tests (#388)
  rc5 (#384)
  fixes stylelintrc glob so that it respects file extensions (#383)
  prep work for rc3 (#381)
  Interactive setup (#378)
  Update webpack.base.js (#365)
  Adds monorepo bootstrap (#377)
  fixes linter peer dependencies (#380)
  Fix typo (#379)
  kyt-cli version bump (#376)
  updates the kyt-cli version (#370)
  fixes cli starter kyt path bug (#369)
  Adds prep for 0.4.0 release candidate (#368)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants