Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add banner property to member #676

Merged
merged 5 commits into from
Oct 22, 2024
Merged

add banner property to member #676

merged 5 commits into from
Oct 22, 2024

Conversation

Lexedia
Copy link
Member

@Lexedia Lexedia commented Jul 12, 2024

Description

This also fixes a bug where if you pass empty query parameters, the resulted URL would look like something like this https://example.org?

Connected issues & other potential problems

-/-

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Lexedia Lexedia added the enhancement New feature or request label Jul 12, 2024
@Lexedia Lexedia added this to the 6.4.0 milestone Jul 12, 2024
@Lexedia Lexedia self-assigned this Jul 12, 2024
@Lexedia Lexedia marked this pull request as ready for review September 7, 2024 14:01
@l7ssha l7ssha marked this pull request as draft September 7, 2024 15:38
@l7ssha l7ssha modified the milestones: 6.4.0, 6.5.0 Oct 4, 2024
@l7ssha l7ssha modified the milestones: 6.5.0, 6.6.0 Oct 10, 2024
@Lexedia Lexedia marked this pull request as ready for review October 22, 2024 13:34
@Lexedia Lexedia merged commit 4041b55 into dev Oct 22, 2024
7 checks passed
@Lexedia Lexedia deleted the feat/members-banners branch October 22, 2024 13:35
@Lexedia Lexedia modified the milestones: 6.6.0, 6.5.0 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Ready to merge
Development

Successfully merging this pull request may close these issues.

3 participants