Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: buffer overflow #346

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Fixed: buffer overflow #346

merged 3 commits into from
Aug 7, 2024

Conversation

dnzbk
Copy link
Collaborator

@dnzbk dnzbk commented Aug 7, 2024 •
edited
Loading

Description

The bug was reproducible only in the Release build and only on Gentoo.

  • use a safer approach of using getrealpath according to the doc
  • using std::string_view instead of std::string& for better performance
  • improved SystemInfoTest to make it more flexible

Testing

  • Linux Debian 12
  • Windows 10
  • macOS Ventura
  • Gentoo 2.15

@dnzbk dnzbk linked an issue Aug 7, 2024 that may be closed by this pull request
1 failure is detected in the test module "SystemTests" #344
Closed
1 task
@dnzbk dnzbk requested review from phnzb and luckedea August 7, 2024 17:27
@dnzbk dnzbk merged commit f89978f into develop Aug 7, 2024
1 check passed
@dnzbk dnzbk deleted the fix/SystemInfoTest branch August 7, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckedea luckedea luckedea approved these changes

@phnzb phnzb Awaiting requested review from phnzb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 failure is detected in the test module "SystemTests"
2 participants
@dnzbk @luckedea