Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused shebangs from repo test fixture scripts #1375

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

musicinmybrain
Copy link
Contributor

These are not really doing any harm, but they are not doing any good either, and are perhaps slightly misleading:

An alternative would be to chmod a+x tests/fixtures/*.sh so that the shebang lines can be useful – and are used, if I read the gix-testtools code correctly.

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides running the script, shebangs can be useful as hints for language detection (editors, GitHub stats). But it shouldn't matter since they all have .sh extensions.

@o2sh o2sh merged commit 54678fe into o2sh:main Jul 22, 2024
10 checks passed
@o2sh o2sh added the chore label Sep 15, 2024
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Sep 23, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [o2sh/onefetch](https://github.com/o2sh/onefetch) | minor | `2.21.0` -> `2.22.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>o2sh/onefetch (o2sh/onefetch)</summary>

### [`v2.22.0`](https://github.com/o2sh/onefetch/blob/HEAD/CHANGELOG.md#2220-2024-09-20)

[Compare Source](o2sh/onefetch@2.21.0...2.22.0)

##### New Features 🎉

-   Add support for nerd font glyphs in languages info by [@&#8203;Localghost385](https://github.com/Localghost385) in o2sh/onefetch#1395
-   \[onefetch.dev] Add nerdfont iconts to the preview by [@&#8203;Localghost385](https://github.com/Localghost385) in o2sh/onefetch#1411
-   Automate publishing crates to crates.io by [@&#8203;musicinmybrain](https://github.com/musicinmybrain) in o2sh/onefetch#1364

##### Bug Fixes 🐛

-   Show future commit dates without panicking by [@&#8203;MalteT](https://github.com/MalteT) in o2sh/onefetch#1389

##### Chores 🧹

-   Re-generate the man page with --no-info by [@&#8203;musicinmybrain](https://github.com/musicinmybrain) in o2sh/onefetch#1376
-   Drop unused shebangs from repo test fixture scripts by [@&#8203;musicinmybrain](https://github.com/musicinmybrain) in o2sh/onefetch#1375

##### Commit Statistics

<csr-read-only-do-not-edit/>

-   3 commits contributed to the release.
-   135 days passed between releases.
-   0 commits were understood as [conventional](https://www.conventionalcommits.org).
-   3 unique issues were worked on: [#&#8203;1389](o2sh/onefetch#1389), [#&#8203;1395](o2sh/onefetch#1395), [#&#8203;1404](o2sh/onefetch#1404)

##### Commit Details

<csr-read-only-do-not-edit/>

<details><summary>view details</summary>

-   **[#&#8203;1389](o2sh/onefetch#1389
    -   Show future commit dates without panicking ([`61ab298`](o2sh/onefetch@61ab298))
-   **[#&#8203;1395](o2sh/onefetch#1395
    -   Add support for nerd font glyphs in languages info ([`6bf1807`](o2sh/onefetch@6bf1807))
-   **[#&#8203;1404](o2sh/onefetch#1404 - Bump gix from 0.64.0 to 0.66.0 in the gix group ([`19f77b2`](o2sh/onefetch@19f77b2))

</details>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants