Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed comments about the certificate pool not being available on Windows #196

Merged
1 commit merged into from
May 14, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 14, 2022

Please describe the change you are making

This change fixes the comments to indicate that golang/go#46287 has now been fixed and certificate pools are available in Go 1.18 and up.

Are you the owner of the code you are sending in, or do you have permission of the owner?

Yes

The code will be published under the BSD 3 clause license. Have you read and understood this license?

Yes

@ghost ghost requested review from engelmi and eslutsky May 14, 2022 16:16
@ghost ghost force-pushed the windows-cert-pool-support branch 2 times, most recently from 5597465 to a765b66 Compare May 14, 2022 16:45
@ghost ghost force-pushed the windows-cert-pool-support branch from a765b66 to 057fd0a Compare May 14, 2022 16:50
@ghost ghost merged commit 06d462c into main May 14, 2022
@ghost ghost deleted the windows-cert-pool-support branch May 14, 2022 17:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants