Adding ballooning support #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
ballooning
branch
2 times, most recently
from
646429e
to
adf38ca
Compare
ghost
enabled auto-merge (rebase)
ghost
mentioned this pull request
eslutsky
reviewed
May 25, 2022
done |
engelmi
reviewed
May 25, 2022
engelmi
reviewed
May 25, 2022
| memoryPolicy := vm.MemoryPolicy() | ||
| ballooning := memoryPolicy.Ballooning() | ||
| if ballooning != testCase.expected { | ||
| t.Fatalf("Incorrect ballooning value") |
There was a problem hiding this comment.
Minor: If we make this Fatalf more expressive, it'll be easier to figure out what is wrong. E.g.
t.Fatalf("Expected balooning value to be %t, but got %t", testCase.expected, balooning)
engelmi
approved these changes
May 25, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the change you are making
Adding support for memory ballooning. It also changes the return of the
MemoryPolicy()function as I discovered that it is always present.Are you the owner of the code you are sending in, or do you have permission of the owner?
Yes
The code will be published under the BSD 3 clause license. Have you read and understood this license?
Yes