Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPRHV-794: added soundcard enabled flag to builder and VM #231

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

engelmi
Copy link
Contributor

@engelmi engelmi commented Jul 20, 2022

Please describe the change you are making

This PR adds the SoundcardEnabled flag to the VM as well as the Builder. This is necessary for

Are you the owner of the code you are sending in, or do you have permission of the owner?

yes

The code will be published under the BSD 3 clause license. Have you read and understood this license?

yes

@engelmi engelmi force-pushed the ocprhv-794-soundcard-enabled branch from 9a9565c to 47a16c4 Compare July 20, 2022 13:07
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a draft PR because there are no tests yet.

vm.go Show resolved Hide resolved
@engelmi engelmi force-pushed the ocprhv-794-soundcard-enabled branch 2 times, most recently from 02c910b to fb479cd Compare July 21, 2022 07:02
@engelmi engelmi force-pushed the ocprhv-794-soundcard-enabled branch from fb479cd to ad47b80 Compare July 21, 2022 07:18
@engelmi engelmi merged commit a2e1928 into main Jul 21, 2022
@engelmi engelmi deleted the ocprhv-794-soundcard-enabled branch July 21, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant