added nic configuration on intialization #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelmi
force-pushed
the
add-nic-on-initialization
branch
from
3dc047d
to
cf304db
Compare
Darth-Mera
approved these changes
Aug 1, 2023
Setting the nic configuration on vm creation enables to set the IP address of the VM statically. Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
force-pushed
the
add-nic-on-initialization
branch
from
cf304db
to
326b0eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the change you are making
This PR introduces an optional VM initialization parameter for NIC configuration. This enables to set the IP address of the VM statically.
Are you the owner of the code you are sending in, or do you have permission of the owner?
yes
The code will be published under the BSD 3 clause license. Have you read and understood this license?
yes