Support ansible 2.14 (#627)

- Remove the 'warn:' argument

See also: ansible/ansible#77411 .

- CI: Ignore command-instead-of-module

Signed-off-by: Yedidyah Bar David <didi@redhat.com>

Signed-off-by: Yedidyah Bar David <didi@redhat.com>

.config/ansible-lint.yml

@@ -15,3 +15,4 @@ warn_list:
  - fqcn[action]
  - name[missing]
  - deprecated-module
+ - command-instead-of-module

changelogs/fragments/627-remove-warn-arg.yml

@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - Remove the 'warn:' argument (https://github.com/oVirt/ovirt-ansible-collection/pull/627).

roles/hosted_engine_setup/tasks/create_target_vm/03_hosted_engine_final_tasks.yml

@@ -54,8 +54,6 @@
     delay: 10
     until: ovf_store_content.rc == 0
     with_items: "{{ ovf_store_disks }}"
-    args:
-      warn: false
   - name: Prepare images
     ansible.builtin.command: >-
       vdsm-client Image prepare storagepoolID={{ datacenter_id }}
@@ -136,7 +134,6 @@
     environment: "{{ he_cmd_lang }}"
     args:
       chdir: "{{ he_local_vm_dir }}"
-      warn: false
     become: true
     become_user: vdsm
     become_method: sudo
@@ -195,8 +192,6 @@
     become_user: vdsm
     become_method: sudo
     changed_when: true
-    args:
-      warn: false
   - name: Initialize metadata volume
     # Data is written at offset 4KiB*host_id and since ovirt supports 250 hosts per dc,
     # we can have maximum 250*4KiB = ~ 1MiB

roles/hosted_engine_setup/tasks/initial_clean.yml

@@ -13,8 +13,6 @@
       '/## beginning of configuration section by
       vdsm-4.[0-9]\+.[0-9]\+/,/## end of configuration section by vdsm-4.[0-9]\+.[0-9]\+/d' {{ item }} || :
     environment: "{{ he_cmd_lang }}"
-    args:
-      warn: false
     with_items:
       - /etc/libvirt/libvirtd.conf
       - /etc/libvirt/qemu.conf
@@ -26,8 +24,6 @@
       sed -i
       '/## beginning of configuration section for VNC encryption/,/##
       end of configuration section for VNC encryption\+/d' /etc/libvirt/qemu.conf
-    args:
-      warn: false
     environment: "{{ he_cmd_lang }}"
     changed_when: true
   - name: Check if vdsm's abrt-action-save-package-data config exists
@@ -87,8 +83,6 @@
     ansible.builtin.command: >-
       sed -i '/## start vdsm-4.[0-9]\+.[0-9]\+ configuration/,/## end vdsm configuration/d' /etc/sasl2/libvirt.conf
     environment: "{{ he_cmd_lang }}"
-    args:
-      warn: false
     tags: ['skip_ansible_lint']
   - name: Stop and disable services
     ansible.builtin.service:

roles/repositories/tasks/rh-subscription.yml

@@ -73,8 +73,6 @@
 
 - name: Enable dnf modules
   ansible.builtin.command: "dnf module enable -y {{ ovirt_repositories_rh_dnf_modules | join(' ') }}"
-  args:
-    warn: false
   when:
     - ovirt_repositories_ovirt_version|string >= '4.4'
     - ovirt_repositories_target_host == 'engine'

roles/repositories/tasks/rpm.yml

@@ -13,8 +13,6 @@
 
 - name: Enable dnf modules
   ansible.builtin.command: "dnf module enable -y {{ ovirt_repositories_ovirt_dnf_modules | join(' ') }}"
-  args:
-    warn: false
   when:
     - ovirt_repositories_ovirt_version|string >= '4.4'
     - ovirt_repositories_target_host == 'engine'

roles/repositories/tasks/satellite-subscription.yml

@@ -20,8 +20,6 @@
 
 - name: Enable dnf modules
   ansible.builtin.command: "dnf module enable -y {{ ovirt_repositories_rh_dnf_modules | join(' ') }}"
-  args:
-    warn: false
   when:
     - ovirt_repositories_ovirt_version|string >= '4.4'
     - ovirt_repositories_target_host == 'engine'