Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roles: hosted_engine_setup: Remove leftover code and omit parameters #281

Merged
merged 1 commit into from
May 31, 2021
Merged

roles: hosted_engine_setup: Remove leftover code and omit parameters #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/hosted_engine_setup-remove-leftovers-code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
minor_changes:
- hosted_engine_setup - Remove leftover code and omit parameters (https://github.com/oVirt/ovirt-ansible-collection/pull/281).
13 changes: 2 additions & 11 deletions roles/hosted_engine_setup/tasks/iscsi_discover.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
---
- include_tasks: auth_sso.yml
- name: Prepare iSCSI parameters
set_fact:
iscsid:
iscsi:
address: "{{ he_iscsi_portal_addr }}"
port: "{{ he_iscsi_portal_port }}"
username: "{{ he_iscsi_discover_username }}"
password: "{{ he_iscsi_discover_password }}"
no_log: true
- name: Fetch host facts
ovirt_host_info:
pattern: name={{ he_host_name }}
Expand All @@ -25,8 +16,8 @@
iscsi:
address: "{{ he_iscsi_portal_addr }}"
port: "{{ he_iscsi_portal_port }}"
username: "{{ he_iscsi_discover_username }}"
password: "{{ he_iscsi_discover_password }}"
username: "{{ he_iscsi_discover_username | default(omit) }}"
password: "{{ he_iscsi_discover_password | default(omit) }}"
register: otopi_iscsi_targets
# TODO: perform an iSCSI logout when viable, see:
# https://bugzilla.redhat.com/show_bug.cgi?id=1535951
Expand Down