-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default_route usage to the ovirt_network module #647
Conversation
3e10bac
to
47e1216
Compare
47e1216
to
2c937bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add changelog fragment documenting this change?
Other than that it looks good to me.
2c937bf
to
d05f8a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the default_route
to the DOCUMENTATION
Signed-off-by: Martin Perina <mperina@redhat.com>
Signed-off-by: Martin Perina <mperina@redhat.com>
4e02825
to
92c13e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add default_route to list of usage properties closes oVirt#648 * Added documentation Signed-off-by: Martin Perina <mperina@redhat.com> * Added changelog Signed-off-by: Martin Perina <mperina@redhat.com> Signed-off-by: Martin Perina <mperina@redhat.com> Co-authored-by: Martin Perina <mperina@redhat.com> Signed-off-by: Martin Nečas <necas.marty@gmail.com>
Currently, it is possible to configure default_route usage through web-UI or API, but not through ansible.