Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default_route usage to the ovirt_network module #647

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

ilush
Copy link
Contributor

@ilush ilush commented Dec 7, 2022

Currently, it is possible to configure default_route usage through web-UI or API, but not through ansible.

@ilush ilush requested a review from mnecas as a code owner December 7, 2022 15:49
@ilush ilush force-pushed the feature/ln_usage_default_route branch from 3e10bac to 47e1216 Compare December 7, 2022 16:13
@mwperina mwperina force-pushed the feature/ln_usage_default_route branch from 47e1216 to 2c937bf Compare December 14, 2022 13:48
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add changelog fragment documenting this change?

Other than that it looks good to me.

@mwperina mwperina force-pushed the feature/ln_usage_default_route branch from 2c937bf to d05f8a4 Compare January 18, 2023 09:19
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the default_route to the DOCUMENTATION

Signed-off-by: Martin Perina <mperina@redhat.com>
Signed-off-by: Martin Perina <mperina@redhat.com>
@mwperina mwperina force-pushed the feature/ln_usage_default_route branch from 4e02825 to 92c13e4 Compare January 18, 2023 12:17
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas merged commit 1c99c0d into oVirt:master Jan 18, 2023
mnecas pushed a commit to dupondje/ovirt-ansible-collection that referenced this pull request Jan 18, 2023
* Add default_route to list of usage properties

closes oVirt#648

* Added documentation

Signed-off-by: Martin Perina <mperina@redhat.com>

* Added changelog

Signed-off-by: Martin Perina <mperina@redhat.com>

Signed-off-by: Martin Perina <mperina@redhat.com>
Co-authored-by: Martin Perina <mperina@redhat.com>
Signed-off-by: Martin Nečas <necas.marty@gmail.com>
@mnecas mnecas mentioned this pull request Feb 14, 2023
@ilush ilush deleted the feature/ln_usage_default_route branch February 14, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants