Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usage of ipaddr filters and remove dependency on python-netaddr #696

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

michalskrivanek
Copy link
Member

No description provided.

@michalskrivanek
Copy link
Member Author

michalskrivanek commented Mar 23, 2023

not sure if it fixes #695 but it's a good thing in any case...

@michalskrivanek
Copy link
Member Author

/ost he-basic-suite-master

@michalskrivanek
Copy link
Member Author

seems to work ok, it now broke on the next dependency, jmespath.

@michalskrivanek
Copy link
Member Author

/ost he-basic-suite-master el9stream

@michalskrivanek
Copy link
Member Author

/ost he-basic-suite-master

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit surprised that ip rule can accept IP/MASK instead of IP/CIDR. But looks good

@michalskrivanek
Copy link
Member Author

tested on el9 with ipv4-only and dual stack

@michalskrivanek
Copy link
Member Author

Bit surprised that ip rule can accept IP/MASK instead of IP/CIDR. But looks good

ah, so that's what it does!:-D dunno, but if the sacred OST says green then why would I even check

@michalskrivanek
Copy link
Member Author

michalskrivanek commented Mar 24, 2023

Bit surprised that ip rule can accept IP/MASK instead of IP/CIDR. But looks good

ah, so that's what it does!:-D dunno, but if the sacred OST says green then why would I even check

reading documentation despite them trying to document the syntax using formal grammar it doesn't really seem to be defined what format it accepts. In other places ip's PREFIX states it's CIDR. Yet, it indeed works just fine, even on RHEL 8.6:

# ip rule add from 192.168.8.3/255.255.255.0 priority 101 table main
# ip rule
101:    from 192.168.8.3/24 lookup main

eh....so let's proceed...:)

@michalskrivanek michalskrivanek merged commit fd20e99 into master Mar 24, 2023
@michalskrivanek
Copy link
Member Author

That’s one small step for man, one giant leap for mankind!

@michalskrivanek michalskrivanek deleted the drop-python-netaddr branch March 24, 2023 09:57
@mnecas
Copy link
Member

mnecas commented Mar 24, 2023

Bit surprised that ip rule can accept IP/MASK instead of IP/CIDR. But looks good

ah, so that's what it does!:-D dunno, but if the sacred OST says green then why would I even check

reading documentation despite them trying to document the syntax using formal grammar it doesn't really seem to be defined what format it accepts. In other places ip's PREFIX states it's CIDR. Yet, it indeed works just fine, even on RHEL 8.6:

# ip rule add from 192.168.8.3/255.255.255.0 priority 101 table main
# ip rule
101:    from 192.168.8.3/24 lookup main

eh....so let's proceed...:)

Yeah I did same test. Also could not find which format they require/support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants