Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle situation when empty groups not come from the keycloak #14

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

0ffer
Copy link
Contributor

@0ffer 0ffer commented Apr 11, 2024

Before the keycloak v22 it sends empty array as group claim when user not a member of any group. After v22 it not put this claim at all.
Look discussion: keycloak/keycloak#22340

@0ffer 0ffer requested a review from mwperina as a code owner April 11, 2024 08:49
@0ffer 0ffer force-pushed the kc-empty-group-claim branch 2 times, most recently from 920a372 to 33621ac Compare April 11, 2024 08:58
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…nce from mod_auth_openidc)

Before the keycloak v22 it sends empty array as group claim when user not in a member of any group.
After v22 it not put this claim at all.
Look discussion: keycloak/keycloak#22340

Signed-off-by: Stanislav Melnichuk <melnichuk.stas@gmail.com>
@mwperina mwperina merged commit 2a7de34 into oVirt:master Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants