Look for InstanceID as well when reading internal OVFs

[shubhaOracle]

Detach 4.3 SD and attach it to 4.5 env fails with error 'Error parsing OVF due to OVF error: ol8-clone: cannot read 'rasd:InstanceId' with value: null'. Ref bug change https://bugzilla.redhat.com/show_bug.cgi?id=1850103

Steps -

• Create a SD in 4.3 env
• Add some test vms to this storage domain
• Detach the SD from 4.3- Compute>Data Center> Click on the DC which has the concerned SD> Select the SD > Maintenance> Detach
• Remove the SD from 4.3- Compute> Storage> Domains> Select the detached SD > Remove
• Goto 4.4 env, Compute>Storage>Domain> Import Domain> add the exisiting path for the SD
• Select the imported SD, goto VM Import tab, If your 4.4.10 env is not having the patch for the BUG, then the test VMs which were created in 4.3 under this SD , wont come up. The engine log will show an error w.r.t all the test VMs when you click on the VM import tab

[smelamud]

Please reformat the commit message in accordance with oVirt standard. (You can take previous commits as an example.) And add more detailed explanation, how the patch fixes the problem.

[ahadas]

@shubhaOracle thanks for posting this! your approach, checking both InstanceId and InstanceID, looks ok to me - but assuming this issue is specific to Oracle's product, I'd change the comment to avoid confusion and start with looking for InstanceId which is supposed to be there and then fall back to checking InstanceID

[shubhaOracle]

I have added 'Signed-off-by:' to my second commit. I am not sure why it is still flagged as a problem.

[michalskrivanek]

I have added 'Signed-off-by:' to my second commit. I am not sure why it is still flagged as a problem.

I think it checks it on all commits.
For this PR it makes sense to squash it into a single commit anyway

[ahadas]

/ost