core: Fail when getVolumeInfo fails during OVF read #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennyz
force-pushed
the
error-on-ovf-get-info-fail
branch
2 times, most recently
from
e9990e3
to
f5d3f8a
Compare
|
/ost |
ahadas
reviewed
Nov 26, 2023
...bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDiskQuery.java
Outdated
Show resolved
Hide resolved
...ll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDisksQuery.java
Outdated
Show resolved
Hide resolved
...ll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/GetUnregisteredDisksQuery.java
Outdated
Show resolved
Hide resolved
bennyz
force-pushed
the
error-on-ovf-get-info-fail
branch
from
f5d3f8a
to
a792cce
Compare
In a scenario where we managed to list the images on the storage, but failed to read get their information from vdsm, we will end up with engine assuming the OVF_STOREs are missing. Instead this patch treats a failure to retrieve the infromation as a failure to force the user to retry. Bug-Url: https://bugzilla.redhat.com/2244641 Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
bennyz
force-pushed
the
error-on-ovf-get-info-fail
branch
from
a792cce
to
b2150e6
Compare
ahadas
approved these changes
Nov 27, 2023
|
/ost basic-suite-master el9stream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a scenario where we managed to list the images on the storage, but failed to read get their information from vdsm, we will end up with engine assuming the OVF_STOREs are missing.
Instead this patch treats a failure to retrieve the infromation as a failure to force the user to retry.
Bug-Url: https://bugzilla.redhat.com/2244641