Underscore 1.7.0 upgrade #1019

simong · 2014-08-27T10:57:26Z

This is due to an underscore 1.7.0 breaking change.
See: jashkenas/underscore#1736

simong · 2014-08-27T10:57:57Z

nicolaasmatthijs · 2014-08-27T12:01:53Z

I'm consistently seeing the same build errors as the ones shown by Travis, so there's probably a bit more going on here.

1) File previews verify previews are downloadable from another tenant:
     Uncaught AssertionError: "undefined" == true
      at /home/travis/build/oaeproject/Hilary/node_modules/oae-content/tests/test-previews.js:537:52
      at /home/travis/build/oaeproject/Hilary/node_modules/oae-search/lib/test/util.js:81:28
      at Request._callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/lib/util.js:9:8823)
      at Request.self.callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:121:22)
      at Request.emit (events.js:98:17)
      at Request.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:978:14)
      at Request.emit (events.js:117:20)
      at IncomingMessage.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:929:12)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:938:16
  2) File previews verify restoring a revision results in an updated thumbnail url for the search document:
     Uncaught AssertionError: "undefined" == true
      at /home/travis/build/oaeproject/Hilary/node_modules/oae-content/tests/test-previews.js:619:32
      at /home/travis/build/oaeproject/Hilary/node_modules/oae-search/lib/test/util.js:96:36
      at Request._callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/lib/util.js:9:8823)
      at Request.self.callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:121:22)
      at Request.emit (events.js:98:17)
      at Request.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:978:14)
      at Request.emit (events.js:117:20)
      at IncomingMessage.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:929:12)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:938:16
  3) General Search Search Scopes verify the "network" search scope searches resources from inside the current tenant network only:
     Uncaught AssertionError: false == true
      at /home/travis/build/oaeproject/Hilary/node_modules/oae-search/tests/test-general-search.js:97:24
      at Request._callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/lib/util.js:9:8823)
      at Request.self.callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:121:22)
      at Request.emit (events.js:98:17)
      at Request.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:978:14)
      at Request.emit (events.js:117:20)
      at IncomingMessage.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:929:12)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:938:16
      at process._tickDomainCallback (node.js:463:13)
  4) General Search Search Scopes verify the "interact" search scope searches only resources with which the user can interact:
     Uncaught AssertionError: false == true
      at /home/travis/build/oaeproject/Hilary/node_modules/oae-search/tests/test-general-search.js:97:24
      at Request._callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/lib/util.js:9:8823)
      at Request.self.callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:121:22)
      at Request.emit (events.js:98:17)
      at Request.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:978:14)
      at Request.emit (events.js:117:20)
      at IncomingMessage.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:929:12)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:938:16
      at process._tickDomainCallback (node.js:463:13)
  5) General Search Search Scopes verify the "tenant" search scope searches resources from inside the current tenant as well as resources the user has access to:
     Uncaught AssertionError: null == true
      at /home/travis/build/oaeproject/Hilary/node_modules/oae-search/tests/test-general-search.js:95:24
      at Request._callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/lib/util.js:9:8823)
      at Request.self.callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:121:22)
      at Request.emit (events.js:98:17)
      at Request.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:978:14)
      at Request.emit (events.js:117:20)
      at IncomingMessage.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:929:12)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:938:16
      at process._tickDomainCallback (node.js:463:13)
  6) General Search Group Search Visibility verify public group is searchable by everyone:
     Uncaught AssertionError: null == true
      at /home/travis/build/oaeproject/Hilary/node_modules/oae-search/tests/test-general-search.js:1879:52
      at Request._callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/lib/util.js:9:8823)
      at Request.self.callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:121:22)
      at Request.emit (events.js:98:17)
      at Request.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:978:14)
      at Request.emit (events.js:117:20)
      at IncomingMessage.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:929:12)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:938:16
      at process._tickDomainCallback (node.js:463:13)
  7) General Search Group Search Visibility verify loggedin group search visibility:
     Uncaught AssertionError: null == true
      at /home/travis/build/oaeproject/Hilary/node_modules/oae-search/tests/test-general-search.js:2024:80
      at Request._callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/lib/util.js:9:8823)
      at Request.self.callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:121:22)
      at Request.emit (events.js:98:17)
      at Request.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:978:14)
      at Request.emit (events.js:117:20)
      at IncomingMessage.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:929:12)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:938:16
      at process._tickDomainCallback (node.js:463:13)
  8) General Search Group Search Visibility verify private group search visibility:
     Uncaught AssertionError: null == true
      at /home/travis/build/oaeproject/Hilary/node_modules/oae-search/tests/test-general-search.js:2201:80
      at Request._callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/lib/util.js:9:8823)
      at Request.self.callback (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:121:22)
      at Request.emit (events.js:98:17)
      at Request.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:978:14)
      at Request.emit (events.js:117:20)
      at IncomingMessage.<anonymous> (/home/travis/build/oaeproject/Hilary/node_modules/oae-rest/node_modules/request/request.js:929:12)
      at IncomingMessage.emit (events.js:117:20)
      at _stream_readable.js:938:16
      at process._tickDomainCallback (node.js:463:13)

nicolaasmatthijs · 2014-08-27T12:02:02Z

Back to @simong for investigation of test failures.

coveralls · 2014-08-27T15:06:46Z

Changes Unknown when pulling 0e1e89d on simong:underscore-1.7.0 into * on oaeproject:master*.

coveralls · 2014-08-27T15:55:52Z

Changes Unknown when pulling 0f006da on simong:underscore-1.7.0 into * on oaeproject:master*.

simong · 2014-08-27T16:05:07Z

Got a properly functioning build at https://travis-ci.org/oaeproject/Hilary/builds/33709119 that downgraded elasticsearch to 1.1.1 and included the underscore fixes.

I've rebased my branch and letting it run for another build

nicolaasmatthijs · 2014-08-27T16:37:41Z

node_modules/oae-content/lib/internal/dao.content.js

@@ -72,8 +72,12 @@ var getMultipleContentItems = module.exports.getMultipleContentItems = function(

    // If `fields` was specified, we select only the fields specified. Otherwise we select all (i.e., *)
    if (fields) {
+        if (!_.isArray(fields)) {


Wouldn't it be better to use OaeUtil.toArray here?

nicolaasmatthijs · 2014-08-27T16:38:22Z

Finished review. Back to @simong for follow-up

simong · 2014-08-27T17:13:32Z

The build succeeded, back to @nicolaasmatthijs for review

nicolaasmatthijs · 2014-08-27T17:17:10Z

Looks good. Merged.

coveralls · 2014-08-27T17:17:26Z

Changes Unknown when pulling e750d5b on simong:underscore-1.7.0 into * on oaeproject:master*.

jdalton · 2014-08-28T14:53:11Z

Related to jashkenas/underscore#1805.

simong added the To Review label Aug 27, 2014

simong assigned simong and nicolaasmatthijs and unassigned simong Aug 27, 2014

nicolaasmatthijs added More work needed and removed To Fix labels Aug 27, 2014

nicolaasmatthijs assigned simong and unassigned nicolaasmatthijs Aug 27, 2014

simong added 2 commits August 27, 2014 16:01

Using _.template(tpl)(data) rather than _.template(tpl, data)

b09b554

_.union only works on iterables since 1.7.0

ef0ce93

simong force-pushed the underscore-1.7.0 branch from 53acc49 to 0e1e89d Compare August 27, 2014 15:03

simong changed the title ~~Using _.template(tpl)(data) rather than _.template(tpl, data)~~ Underscore 1.7.0 upgrade Aug 27, 2014

simong added 2 commits August 27, 2014 17:03

Pointing underscore to latest again

c809e85

Installing elasticsearch 1.1.1 manually for Travis

477f882

simong force-pushed the underscore-1.7.0 branch from 0f006da to 477f882 Compare August 27, 2014 16:03

nicolaasmatthijs reviewed Aug 27, 2014
View reviewed changes

Using OaeUtil.toArray to ensure column fields are arrays

e750d5b

simong assigned nicolaasmatthijs and unassigned simong Aug 27, 2014

simong added To Review and removed More work needed labels Aug 27, 2014

nicolaasmatthijs merged commit e750d5b into oaeproject:master Aug 27, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Underscore 1.7.0 upgrade #1019

Underscore 1.7.0 upgrade #1019

simong commented Aug 27, 2014

simong commented Aug 27, 2014

nicolaasmatthijs commented Aug 27, 2014

nicolaasmatthijs commented Aug 27, 2014

coveralls commented Aug 27, 2014

coveralls commented Aug 27, 2014

simong commented Aug 27, 2014

nicolaasmatthijs Aug 27, 2014

nicolaasmatthijs commented Aug 27, 2014

simong commented Aug 27, 2014

nicolaasmatthijs commented Aug 27, 2014

coveralls commented Aug 27, 2014

jdalton commented Aug 28, 2014

Underscore 1.7.0 upgrade #1019

Underscore 1.7.0 upgrade #1019

Conversation

simong commented Aug 27, 2014

simong commented Aug 27, 2014

nicolaasmatthijs commented Aug 27, 2014

nicolaasmatthijs commented Aug 27, 2014

coveralls commented Aug 27, 2014

coveralls commented Aug 27, 2014

simong commented Aug 27, 2014

nicolaasmatthijs Aug 27, 2014

Choose a reason for hiding this comment

nicolaasmatthijs commented Aug 27, 2014

simong commented Aug 27, 2014

nicolaasmatthijs commented Aug 27, 2014

coveralls commented Aug 27, 2014

jdalton commented Aug 28, 2014