fix: use NextResponse.json() in case of middleware errors #150

mantagen · 2024-09-23T08:42:47Z

Description

currently PR'd as a hotfix to production
attempt to get fewer of these errors https://oak-national-academy.sentry.io/issues/214659/?project=4507089597300816
code copied from NextResponse docs
hard to know if this is the issue, as there are few details in the Sentry event. But this is the only place we call .error() on a response object
also, for this code to have been running, there would have been an error in this code:

    response = await authMiddleware(request, event);
    response = addCspHeaders(response, request);

vercel · 2024-09-23T08:42:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
oak-ai-lesson-assistant	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 8:44am

sonarcloud · 2024-09-23T08:44:40Z

github-actions · 2024-09-23T08:46:27Z

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

oak-machine-user · 2024-09-23T08:57:26Z

🎉 This PR is included in version 1.7.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fix: use NextResponse.json() in case of middleware errors

da43bd2

mantagen requested a review from a team September 23, 2024 08:42

vercel bot deployed to Preview September 23, 2024 08:44 View deployment

codeincontext approved these changes Sep 23, 2024

View reviewed changes

mantagen merged commit 73259a2 into production Sep 23, 2024
13 checks passed

mantagen deleted the fix/error-method branch September 23, 2024 08:56

oak-machine-user added the released label Sep 23, 2024

mantagen added a commit that referenced this pull request Oct 3, 2024

fix: use NextResponse.json() in case of middleware errors (#150)

c02746a