Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: donwload all button #152

Merged
merged 47 commits into from
Sep 27, 2024
Merged

feat: donwload all button #152

merged 47 commits into from
Sep 27, 2024

Conversation

tomwisecodes
Copy link
Contributor

@tomwisecodes tomwisecodes commented Sep 23, 2024

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 9:03am

Copy link

github-actions bot commented Sep 23, 2024

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

Copy link
Collaborator

@mantagen mantagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good -- couple logs left in there

if (!active) {
return;
}
console.log("STARTING");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can lose the logs

const debouncedParseResult = useDebounce(parseResult, 500);

useEffect(() => {
console.log("Use Export Lesson Slides");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can lose

Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
33.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tomwisecodes tomwisecodes merged commit 732b778 into main Sep 27, 2024
11 of 13 checks passed
@tomwisecodes tomwisecodes deleted the feat/donwload-all-button branch September 27, 2024 09:05
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mantagen pushed a commit that referenced this pull request Oct 3, 2024
Co-authored-by: Joe Baker <JBR90@users.noreply.github.com>
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants