Check a fallback case in validation: using literal partition key in window function #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHILO-HE
force-pushed
the
partition-by-literal-rebased
branch
from
75919a5 to
e1d53e8
Compare
rui-mo
approved these changes
Mar 10, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Mar 27, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Mar 29, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Mar 29, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Apr 14, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Apr 17, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Apr 19, 2023
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Apr 20, 2023
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 31, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 3, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 4, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 11, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 12, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
zhejiangxiaomai
added a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jul 17, 2023
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is not allowed in Velox to use literal as partition key in window function, which is a rare use case. So we are blocking this case in validator to make fallback possible for this case.