feat: added format support to the changelog mode #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbergstroem
reviewed
Sep 26, 2024
| @@ -66,6 +66,7 @@ Additional arguments: | |||
|
|
|||
| | CLI | Action input | Default | | |||
| | --------------------- | ------------------- | ------- | | |||
| | --format | format | yaml | | |||
There was a problem hiding this comment.
I think default should be the same as cli (text)
jbergstroem
reviewed
Sep 26, 2024
|
|
||
| echo "running oasdiff changelog base: $base, revision: $revision, include_path_params: $include_path_params, exclude_elements: $exclude_elements, composed: $composed, output_to_file: $output_to_file" | ||
|
|
||
| # Build flags to pass in command | ||
| flags="" | ||
| if [ "$format" != "yaml" ]; then |
There was a problem hiding this comment.
I would validate format here. I was actually about to open a PR that achieves the same where I did something like:
validate_format() {
local -a output_formats=(githubactions html json junit markup singleline text yaml)
for f in "${output_formats[@]}"; do
[[ "${f}" == "${1}" ]] && return 0
done
return 1
}
validate_format $format || { echo "Invalid format: ${format}" >&2; exit 1; }
|
Left some comments; I didn't check open PRs before I attempted to achieve the same. My commit is here: jbergstroem@22a8d89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.