Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic equivalence approach #301

Merged
merged 2 commits into from
Oct 16, 2019

Conversation

emmanvg
Copy link
Contributor

@emmanvg emmanvg commented Oct 15, 2019

  • add more detailed output via the logging module
  • don't fail hard if an object sent to the semantically_equivalent() method does not have a config section for the object type
  • remove specific exception related to Semantic Equivalence and update tests accordingly

closes #293
closes #294

- add more detailed output via the logging module
- don't fail hard if an object sent to the semantically_equivalent() method
- remove specific exception related to Semantic Equivalence and tests
@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #301 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   98.13%   98.14%   +0.01%     
==========================================
  Files         123      123              
  Lines       13777    13837      +60     
==========================================
+ Hits        13520    13581      +61     
+ Misses        257      256       -1
Impacted Files Coverage Δ
stix2/exceptions.py 100% <ø> (ø) ⬆️
stix2/test/v21/test_environment.py 100% <100%> (ø) ⬆️
stix2/environment.py 100% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e1ddb...13fda69. Read the comment docs.

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thank you!

@clenk clenk merged commit ec115b3 into oasis-open:master Oct 16, 2019
@emmanvg emmanvg deleted the 294-semantic-methods branch October 16, 2019 14:02
@emmanvg emmanvg added this to the 1.2.1 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants