Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #338 #347

Closed
wants to merge 4 commits into from
Closed

Fixes #338 #347

wants to merge 4 commits into from

Conversation

khdesai
Copy link
Contributor

@khdesai khdesai commented Feb 19, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #347 into master will decrease coverage by 0.02%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   98.17%   98.15%   -0.03%     
==========================================
  Files         124      124              
  Lines       14182    14170      -12     
==========================================
- Hits        13923    13908      -15     
- Misses        259      262       +3
Impacted Files Coverage Δ
stix2/v21/sdo.py 94.44% <ø> (-0.1%) ⬇️
stix2/test/v21/test_course_of_action.py 100% <ø> (ø) ⬆️
stix2/v21/observables.py 96.93% <100%> (-0.21%) ⬇️
stix2/test/v21/test_observed_data.py 100% <100%> (ø) ⬆️
stix2/base.py 97.8% <82.35%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d447fa...ccb2b9d. Read the comment docs.

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec_version is still a required common property on CoA. Also, while the properties have been rolled back to how they were in 2.0, we still need to specify spec_version='2.1' on the common properties. It's not using the 2.0 version of common properties.

@emmanvg emmanvg added this to the 1.4.0 milestone Mar 3, 2020
Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confidence and lang are also common properties that should still be present. Sorry; should have noticed that earlier.

@clenk clenk closed this in 5abc139 Mar 12, 2020
@clenk
Copy link
Contributor

clenk commented Mar 12, 2020

Rebased and merged in; thanks @khdesai!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants