-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #338 #347
Fixes #338 #347
Conversation
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
- Coverage 98.17% 98.15% -0.03%
==========================================
Files 124 124
Lines 14182 14170 -12
==========================================
- Hits 13923 13908 -15
- Misses 259 262 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spec_version
is still a required common property on CoA. Also, while the properties have been rolled back to how they were in 2.0, we still need to specify spec_version='2.1'
on the common properties. It's not using the 2.0 version of common properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confidence
and lang
are also common properties that should still be present. Sorry; should have noticed that earlier.
Rebased and merged in; thanks @khdesai! |
No description provided.